Fix CAPI Machine name lookup, add Ready column, expand reconcile logging#62
Merged
Conversation
…ing The reconciler had been constructing CAPI Machine names as `{sm}-machine` in two lookup paths while the create path (add_machine_to_cluster) writes the Machine with the bare SM name. Lookups silently 404'd in the field — status enrichment and pre-drain node lookup never matched the real Machine. Both call sites now use `&name` directly; the kind suffix is gone.
Signed-off-by: Erick Bourgeois <erick@jeb.ca>
ebourgeois
changed the title
{sm}-machine in two lookup paths while the create path (add_machine_to_cluster) writes the Machine with the bare SM name. Lookups silently 404'd in the field — status enrichment and pre-drain node lookup never matched the real Machine. Both call sites now use &name directly; the kind suffix is gone.
prabhjotbawa
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reconciler had been constructing CAPI Machine names as
{sm}-machinein two lookup paths while the create path (add_machine_to_cluster) writes
the Machine with the bare SM name. Lookups silently 404'd in the field —
status enrichment and pre-drain node lookup never matched the real Machine.
Both call sites now use
&namedirectly; the kind suffix is gone